Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Include LA64 in supported ILCompiler RIDs #42657

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Include LA64 in supported ILCompiler RIDs #42657

merged 2 commits into from
Aug 13, 2024

Conversation

am11
Copy link
Member

@am11 am11 commented Aug 10, 2024

@am11
Copy link
Member Author

am11 commented Aug 12, 2024

cc @akoeplinger

@marcpopMSFT
Copy link
Member

Triage: @richlander do we have any documentation on how customers should go about adding these community rids and which ones we'll take?

@am11
Copy link
Member Author

am11 commented Aug 13, 2024

There is nothing new here, loongarch is supported since net60 (see the rest of this file). Its ILCompiler support was added recently in net90.

@baronfel
Copy link
Member

@am11 we (SDK team) don't have good knowledge of what platform capabilities are incoming or in flight - is there an epic for 'light up loongarch for XYZ functionality' or something that helps us know that this is part of some unified unit of effort? Or is there another team that should be reviewing this?

@richlander
Copy link
Member

These are not so much community RIDs as community architectures.

The big push on RIDs in the past was to get us focused on linux, which we did. We have no issue with adding new architectures. They are not coming at near the pace of distros.

I have no concerns with these changes.

@jkotas @agocke @elinor-fung

@baronfel baronfel merged commit ddbc223 into dotnet:main Aug 13, 2024
37 checks passed
@baronfel
Copy link
Member

Thanks for the clarity folks - in the future an epic or something would make these kinds of PRs much more routine.

@jkotas
Copy link
Member

jkotas commented Aug 13, 2024

I agree with @richlander .

The architecture that requires hardcoding the lists of RIDs in the SDK is a bit of unfortunate. I think it would be better to just depend on a package availability, but that's not a simple fix.

@jkotas
Copy link
Member

jkotas commented Aug 13, 2024

in the future an epic or something would make these kinds of PRs much more routine.

This is our documentation for contributing ports: https://github.com/dotnet/runtime/blob/main/CONTRIBUTING.md#contributing-ports

@am11 am11 deleted the patch-2 branch August 13, 2024 21:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants