Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[StaticWebAssets] Avoid serializing/deserializing manifest for hash #43710

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Sep 26, 2024

The actual win is around ~.5s even if it doesn't show up in this particular run. With so few measurements included (for the sake of conciseness).

Before
image

Build succeeded in 12.8s
You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
  mvc-dotnet-9 succeeded (11.8s) → bin\Debug\net9.0\mvc-dotnet-9.dll

Build succeeded in 12.7s
You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
  mvc-dotnet-9 succeeded (11.6s) → bin\Debug\net9.0\mvc-dotnet-9.dll

Build succeeded in 12.6s
You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
  mvc-dotnet-9 succeeded (11.7s) → bin\Debug\net9.0\mvc-dotnet-9.dll

Build succeeded in 12.6s

After
image

You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
  mvc-dotnet-9 succeeded (11.3s) → bin\Debug\net9.0\mvc-dotnet-9.dll

Build succeeded in 12.2s
You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
  mvc-dotnet-9 succeeded (11.3s) → bin\Debug\net9.0\mvc-dotnet-9.dll

Build succeeded in 12.3s
You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
  mvc-dotnet-9 succeeded (11.3s) → bin\Debug\net9.0\mvc-dotnet-9.dll

Build succeeded in 12.2s

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Sep 26, 2024
@javiercn javiercn marked this pull request as ready for review September 26, 2024 15:50
@javiercn javiercn enabled auto-merge (squash) September 26, 2024 20:05
@javiercn javiercn force-pushed the javiercn/avoid-reading-manifest-for-hash branch from 3c2eb66 to e2b1206 Compare September 27, 2024 09:34
@javiercn javiercn changed the title [StaticWebAssets] Avoid reading manifest for hash [StaticWebAssets] Avoid serializing/deserializing manifest for hash Sep 27, 2024
@javiercn javiercn force-pushed the javiercn/avoid-reading-manifest-for-hash branch from e5b264e to f98f111 Compare October 7, 2024 09:48
@javiercn javiercn force-pushed the javiercn/avoid-reading-manifest-for-hash branch from d9277ee to 94e430f Compare October 7, 2024 13:15
@javiercn javiercn merged commit c5dbaed into main Oct 7, 2024
37 checks passed
@javiercn javiercn deleted the javiercn/avoid-reading-manifest-for-hash branch October 7, 2024 15:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants