[release/8.0.4xx] Fix regression - single arch scenario with no rid specified #45746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
surayya-MS
added
DO NOT MERGE
Servicing-consider
Servicing-approved
and removed
untriaged
|
Approved over the email |
SimaTian
approved these changes
Jan 8, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes dotnet/sdk-container-builds#610
In a single arch scenario when no
RuntimeIdentifieris specified, the produced container cannot be run. This is a very common scenario for single arch.This is a regression that was caused by #43085 PR.
Customer impact
Without this fix, customers will not be able to run the published containers in single arch scenario when no
RuntimeIdentifieris specified. They were able to do this before the regression.Details
The problem is that the
ContainerAppCommanditem is missingdotnet. In the PR aboveContainerAppCommandsetting was changed to checkUseAppHostproperty instead of_ContainerIsSelfContainedhttps://github.com/dotnet/sdk/pull/43085/files#diff-a5f4ada40b043c8a36b7a1d56148dcfd0abcfe13fa82dbfb456f7c43bebedff7L103This works for the cases when
RuntimeIdentfieris specified, but not for the cases when it is not.The tests did not catch this because there is no test covering this specific scenario with no
RuntimeIdentifierspecified - all single arch tests specify aRuntimeIdentifier.Changes made
Fixed by setting
ContainerAppCommandcorrectly.Testing
Added a test to cover this scenario. Also tested manually.
Risks
Low - new test ensures the scenario is now covered, the existing tests ensure that other scenarios were not affected.