Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Enable dotnet-format test for SB #46331

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Enable dotnet-format test for SB #46331

merged 2 commits into from
Jan 29, 2025

Conversation

mthalman
Copy link
Member

@mthalman mthalman requested review from a team as code owners January 27, 2025 13:58
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jan 27, 2025
@mthalman
Copy link
Member Author

The test still isn't passing. The fix was made in #46324. But we're still using the version of the sdk w/o this fix to build roslyn. So this will require a rebootstrap. The stage 2 build would have confirmed this but it was disabled by #46269, ironically enough.

@build-analysis build-analysis bot mentioned this pull request Jan 27, 2025
Open
@mthalman mthalman changed the base branch from main to release/10.0.1xx-preview1 January 29, 2025 15:55
This was referenced Jan 29, 2025
Open
Open
Open
Open
Open
@mthalman mthalman merged commit 1769c35 into dotnet:release/10.0.1xx-preview1 Jan 29, 2025
29 of 32 checks passed
@mthalman mthalman deleted the sb4835 branch January 29, 2025 19:26
@mthalman
Copy link
Member Author

/backport to main

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to main: https://github.com/dotnet/sdk/actions/runs/13038900048

@github-actions github-actions bot mentioned this pull request Jan 29, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable format test
3 participants
@mthalman @akoeplinger @MichaelSimons