Stop copying PSB reference packages #48397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (4)
- src/SourceBuild/content/Directory.Build.props: Language not supported
- src/SourceBuild/content/eng/finish-source-only.proj: Language not supported
- src/SourceBuild/content/eng/init-source-only.proj: Language not supported
- src/SourceBuild/content/eng/tools/Directory.Build.props: Language not supported
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
akoeplinger
approved these changes
Apr 11, 2025
NikolaMilosavljevic
approved these changes
Apr 11, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4978
init-source-build.proj was updated to no longer copy the reference packages out of PSB. Instead the two places where they are required now reference them directly from the PSB folder. Aside from fixing dotnet/source-build#4978, this provides the added benefit that SBRP itself will build with no PSB reference packages available to it. This is a nice safety check to ensure it is able to build self-contained.