Update maintenance-packages pruning versions #49092

ericstj · 2025-05-21T20:58:03Z

This updates pruning versions for maintenance-packages. We do so only on frameworks where they were previously pruning the version just before the maintenance-package version.

Copilot

Pull Request Overview

This pull request updates the pruning versions for maintenance packages in the .NET build tasks, ensuring that only frameworks previously pruning the version just before the maintenance-package version are updated.

Updated maintenance-package versions for NETStandard2.1, NETCoreApp3.1, NETCoreApp2.1, NET6.0, and NET5.0 frameworks.
Bumps include packages such as System.Buffers, System.Memory, System.Numerics.Vectors, System.Reflection.DispatchProxy, among others.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netstandard2.1.cs	Bumped versions for System.Buffers, System.Memory, System.Numerics.Vectors, and System.Threading.Tasks.Extensions.
src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp3.1.cs	Updated System.Reflection.DispatchProxy version.
src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp2.1.cs	Updated versions for System.Memory, System.Numerics.Vectors, System.Threading.Tasks.Extensions, and System.ValueTuple.
src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.net6.0.cs	Raised the version for System.Runtime.CompilerServices.Unsafe.
src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.net5.0.cs	Updated System.Reflection.DispatchProxy version.

This updates pruning versions for maintenance-packages. We do so only on frameworks where they were previously pruning the version just before the maintenance-package version.

ericstj · 2025-05-21T21:03:57Z

src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp2.1.cs

@@ -17,23 +17,23 @@ internal static class NETCoreApp21
            { "Microsoft.NETCore.App", "2.1.0" },
            { "Microsoft.VisualBasic", "10.3.0" },
            { "Microsoft.Win32.Registry", "4.5.0" },
-            { "System.Buffers", "4.5.0" },
+            { "System.Buffers", "4.6.1" },


We cannot change

sdk/src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp2.0.cs

Line 171 in 380b99b

{ "System.Buffers", "4.4.0" },

because netcoreapp2.0 only included assembly 4.0.2.0 while the package has 4.0.3.0.

ericstj · 2025-05-21T21:07:37Z

src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp2.1.cs

-            { "System.Memory", "4.5.5" },
-            { "System.Numerics.Vectors", "4.5.0" },
+            { "System.Memory", "4.6.3" },
+            { "System.Numerics.Vectors", "4.6.1" },


We cannot change

sdk/src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp2.0.cs

Line 185 in 0e185be

{ "System.Numerics.Vectors", "4.4.0" },

because netcoreapp2.0 only included assembly 4.1.3.0 while the package has 4.1.4.0.

ericstj · 2025-05-21T21:15:09Z

src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp3.1.cs

@@ -19,7 +19,7 @@ internal static class NETCoreApp31
            { "System.ComponentModel.Annotations", "4.7.0" },
            { "System.Diagnostics.DiagnosticSource", "4.7.0" },
            { "System.IO.FileSystem.AccessControl", "4.7.0" },
-            { "System.Reflection.DispatchProxy", "4.7.0" },
+            { "System.Reflection.DispatchProxy", "4.8.2" },


We cannot change

sdk/src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp2.0.cs

Line 189 in 0e185be

{ "System.Reflection.DispatchProxy", "4.4.0" },

sdk/src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp2.1.cs

Line 28 in 0e185be

{ "System.Reflection.DispatchProxy", "4.5.0" },

sdk/src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp3.0.cs

Line 25 in 0e185be

{ "System.Reflection.DispatchProxy", "4.6.0" },

sdk/src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netstandard2.1.cs

Line 31 in 0e185be

{ "System.Reflection.DispatchProxy", "4.5.1" },

Because of the following versions in framework, while the package uses 4.0.6.0:

Framework Version in Framework

netcoreapp2.0 4.0.3.0

netcoreapp2.1 4.0.4.0

netcoreapp3.1 4.0.5.0

netstandard2.1 4.0.5.0

ericstj · 2025-05-21T21:16:32Z

src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.net6.0.cs

@@ -18,7 +18,7 @@ internal static class NETCoreApp60
            { "System.Formats.Asn1", "6.0.0" },
            { "System.Net.Http.Json", "6.0.0" },
            { "System.Reflection.Metadata", "6.0.0" },
-            { "System.Runtime.CompilerServices.Unsafe", "6.0.0" },
+            { "System.Runtime.CompilerServices.Unsafe", "6.1.2" },


We can't change past versions for this, of course, because it was still shipping major versions/API.

ericstj · 2025-05-21T21:20:22Z

src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp2.1.cs

            { "System.Reflection.DispatchProxy", "4.5.0" },
            { "System.Reflection.Metadata", "1.6.0" },
            { "System.Security.AccessControl", "4.5.0" },
            { "System.Security.Cryptography.Cng", "4.5.2" },
            { "System.Security.Cryptography.OpenSsl", "4.5.0" },
            { "System.Security.Principal.Windows", "4.5.0" },
            { "System.Threading.Tasks.Dataflow", "4.9.0" },
-            { "System.Threading.Tasks.Extensions", "4.5.4" },
-            { "System.ValueTuple", "4.5.0" },
+            { "System.Threading.Tasks.Extensions", "4.6.3" },


We cannot change

sdk/src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp2.0.cs

Line 207 in 0e185be

{ "System.Threading.Tasks.Extensions", "4.4.0" },

because netcoreapp2.0 only included assembly 4.1.1.0 while the package has 4.2.1.0

Versions 4.4.0 and later for this package all have a placeholder for `netstandard2.0` so it's safe to prune as it doesn't expose any reference.

ViktorHofer

"System.Runtime.CompilerServices.Unsafe", "6.1.2"

This means that we would need to update this data every time m-p publishes new packages, right? For PackageOverrides.txt entries we chose the next major version: https://github.com/dotnet/runtime/blob/e163124bce28b7e868b62f4efd498fcaa7f95301/src/installer/pkg/sfx/Microsoft.NETCore.App/PackageOverrides.txt#L225

Can we do the same here? In general it would be good use the same versions as in PackageOverrides.txt for these m-p packages.

ericstj · 2025-05-28T15:47:58Z

"System.Runtime.CompilerServices.Unsafe", "6.1.2"

This means that we would need to update this data every time m-p publishes new packages, right? For PackageOverrides.txt entries we chose the next major version: https://github.com/dotnet/runtime/blob/e163124bce28b7e868b62f4efd498fcaa7f95301/src/installer/pkg/sfx/Microsoft.NETCore.App/PackageOverrides.txt#L225

Can we do the same here? In general it would be good use the same versions as in PackageOverrides.txt for these m-p packages.

I think @dsplaisted already employ's lifting of these package versions

sdk/src/Tasks/Microsoft.NET.Build.Tasks/GetPackagesToPrune.cs

Lines 214 to 223 in 2310f2b

    
           if (key.TargetFrameworkIdentifier.Equals(".NETCoreApp", StringComparison.OrdinalIgnoreCase) && !p.Value.IsPrerelease) 
        
           { 
        
               //  If a given version of a package is included in a framework, assume that any patches 
        
               //  to that package will be included in patches to the framework, and thus should be pruned. 
        
               //  See https://github.com/dotnet/sdk/issues/44566 
        
               //  To do this, we set the patch version for the package to be pruned to 32767, which should be 
        
               //  higher than any actual patch version. 
        
               var maxPatch = new NuGetVersion(p.Value.Major, p.Value.Minor, 32767); 
        
               version = maxPatch.ToString(); 
        
           }

ViktorHofer · 2025-05-28T15:56:40Z

If I read the code correctly, only if the package uses a prerelease version. The m-p ones use a stable version.

ericstj · 2025-05-28T19:16:34Z

If I read the code correctly, only if the package uses a prerelease version. The m-p ones use a stable version.

No - it's for non-prerelease. It's disabled for pre-release where API and features of the package might be changing more often. Once the package is released we're in "servicing" in which case this rule to prune higher patch versions is applied.

ViktorHofer · 2025-05-28T20:21:06Z

Sounds good. Should conflict resolution get updated to use the same algorithm?

ericstj · 2025-06-02T17:21:06Z

Sounds good. Should conflict resolution get updated to use the same algorithm?

No I don't think so. Conflict resolution doesn't need to approximate. It also knows nothing about frameworks today. It's much more general purpose.

The reason we do this for pruning is because we have a specific opinion/policy about the packages that overlap with .NETCore.

ericstj · 2025-06-02T17:22:19Z

/azp run dotnet-sdk-public-ci

azure-pipelines · 2025-06-02T17:22:32Z

Azure Pipelines successfully started running 1 pipeline(s).

ViktorHofer · 2025-06-02T17:34:15Z

Thanks for your patience when addressing my questions. Last one:

No - it's for non-prerelease. It's disabled for pre-release where API and features of the package might be changing more often. Once the package is released we're in "servicing" in which case this rule to prune higher patch versions is applied.

So every time we bump the major/minor version of these m-p packages, we would need to update these versions here. Do we expect more minor version m-p updates going forward? If so, would it be better to use a high minor and patch version instead? I.e. 6.99.99.

ericstj · 2025-06-02T17:36:35Z

We expect no minor version updates from maintenance-packages.

ericstj · 2025-06-02T19:40:29Z

I'll add to this that it's really just a convenience. Most of these packages now use placeholders for frameworks where they are dropped, and most of their dependencies from newer versions are up to date, so removing them just saves on download - not false positives or large unused package graphs.

ericstj · 2025-06-02T19:44:28Z

Sounds good. Should conflict resolution get updated to use the same algorithm?

No I don't think so. Conflict resolution doesn't need to approximate. It also knows nothing about frameworks today. It's much more general purpose.

The reason we do this for pruning is because we have a specific opinion/policy about the packages that overlap with .NETCore.

Thinking more about this, I think we had previously suggested this just for PackageOverrides.txt, so I'll file an issue for @dsplaisted to follow up.

Copilot AI review requested due to automatic review settings May 21, 2025 20:58

Copilot AI reviewed May 21, 2025

View reviewed changes

Update maintenance-packages pruning versions

380b99b

This updates pruning versions for maintenance-packages. We do so only on frameworks where they were previously pruning the version just before the maintenance-package version.

ericstj force-pushed the addMPVersionsToFrameworkPackages branch from e968482 to 380b99b Compare May 21, 2025 21:01

ericstj commented May 21, 2025

View reviewed changes

Update ValueTuple for netstandard2.0

eaabd74

Versions 4.4.0 and later for this package all have a placeholder for `netstandard2.0` so it's safe to prune as it doesn't expose any reference.

ericstj requested review from dsplaisted and ViktorHofer May 21, 2025 21:26

ViktorHofer reviewed May 22, 2025

View reviewed changes

ericstj requested a review from ViktorHofer May 28, 2025 15:48

ViktorHofer approved these changes Jun 2, 2025

View reviewed changes

build-analysis bot mentioned this pull request Jun 2, 2025

Throttling of Docker Downloads dotnet/arcade#15659

Open

3 tasks

This was referenced Jun 2, 2025

Should conflict resolution lift the versions read from PackageOverrides.txt #49232

Open

Microsoft.DotNet.Watch.UnitTests.FileWatcherTests.DeleteSubfolder has flaky test assertion #49233

Open

Framework	Version in Framework
netcoreapp2.0	`4.0.3.0`
netcoreapp2.1	`4.0.4.0`
netcoreapp3.1	`4.0.5.0`
netstandard2.1	`4.0.5.0`

Update maintenance-packages pruning versions #49092

Are you sure you want to change the base?

Update maintenance-packages pruning versions #49092

Uh oh!

Conversation

ericstj commented May 21, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

ericstj May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ericstj May 21, 2025

Choose a reason for hiding this comment

Uh oh!

ericstj May 21, 2025

Choose a reason for hiding this comment

Uh oh!

ericstj May 21, 2025

Choose a reason for hiding this comment

Uh oh!

ericstj May 21, 2025

Choose a reason for hiding this comment

Uh oh!

ViktorHofer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ericstj commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ViktorHofer commented May 28, 2025

Uh oh!

ericstj commented May 28, 2025

Uh oh!

ViktorHofer commented May 28, 2025

Uh oh!

ericstj commented Jun 2, 2025

Uh oh!

ericstj commented Jun 2, 2025

Uh oh!

azure-pipelines bot commented Jun 2, 2025

Uh oh!

ViktorHofer commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericstj commented Jun 2, 2025

Uh oh!

ericstj commented Jun 2, 2025

Uh oh!

ericstj commented Jun 2, 2025

Uh oh!

Uh oh!

ericstj May 21, 2025 •

edited

Loading

ViktorHofer left a comment •

edited

Loading

ericstj commented May 28, 2025 •

edited

Loading

ViktorHofer commented Jun 2, 2025 •

edited

Loading