Remove analyzers from aspnetcore targeting pack #1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBRP targeting packs can't have analyzers as those execute and SBRP packages are contract only.
|
@dotnet/source-build these targeting packs get auto-generated via an internal tooling. Can we update that tooling to not include the "analyzers" folder (if that's not already the case) and also trim out the"/analyzer*" entries from the FrameworkList.xml? |
@ViktorHofer, would you mind logging an issue for this. It is called out in the documentation for adding targeting packs but should be handled by the tooling. |
MichaelSimons
approved these changes
Mar 14, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SBRP targeting packs can't have analyzers as those execute and SBRP packages are contract only.
Unblocks dotnet/sdk#47509