Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

prep.sh should be more modular #3283

Closed
crummel opened this issue Mar 2, 2023 · 2 comments
Closed

prep.sh should be more modular #3283

crummel opened this issue Mar 2, 2023 · 2 comments
Assignees
@mthalman
Labels
area-infra Source-build infrastructure and reporting

Comments

@crummel
Copy link
Contributor

crummel commented Mar 2, 2023

prep.sh actually can do four different things:

  • Download a MSFT-built SDK
  • Download MSFT-built previously-source-built artifacts
  • Additionally download portable packages and insert them into the previously-source-built archive (bootstrap scenario)
  • Download known prebuilts for the current release (generally previews only)

We should break these out so that the default behavior is to do all four of these things but each individual behavior can be disabled with an argument like --no-sdk or --skip-sdk, etc.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-build Improvements in source-build's own build process untriaged labels Mar 2, 2023
@MichaelSimons MichaelSimons added area-infra Source-build infrastructure and reporting and removed area-build Improvements in source-build's own build process untriaged labels Mar 2, 2023
@MichaelSimons MichaelSimons moved this to 8.0 Preview 3 in .NET Source Build Mar 2, 2023
@lbussell
Copy link
Contributor

lbussell commented Mar 2, 2023

When this issue is completed, we should update the N-1 CI leg to include the --no-sdk option, as the point of that leg is to acquire its own SDK.

@lbussell lbussell mentioned this issue Mar 3, 2023
Merged
@mthalman mthalman moved this from 8.0 Preview 3 to In Progress in .NET Source Build Mar 3, 2023
@mthalman mthalman mentioned this issue Mar 3, 2023
Closed
@MichaelSimons
Copy link
Member

Fixed by dotnet/installer#15697

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Mar 14, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mthalman mthalman

Labels
area-infra Source-build infrastructure and reporting
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add modular options to SB prep scripts mthalman/installer
4 participants
@crummel @MichaelSimons @mthalman @lbussell