[main] Add CI for building with previously source-built SDK #15603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current build failure is in roslyn. Looks like our tooling is trying to override the windowsdesktop SDK but it isn't actually working: |
|
The current build failure looks legitimate and not related to the CI setup, so I'm requesting review (Build failure is still the same after merging in main). I'll move the new leg back to internal validation only before we merge. I will also file a follow-up issue afterwards to address the root issue of the failure here. |
| # Temporarily move this to PR build just to test the N-1 CI | ||
| - template: ../jobs/vmr-build.yml | ||
| parameters: | ||
| buildName: CentOSStream8_WithPreviousSDK |
There was a problem hiding this comment.
I think there's a need to get crisper on our leg names especially after this additional leg. For example this name doesn't properly differentiate itself with Fedora36_Offline_Using_Previous.
Here are some suggestion groupings
Stage1_CentOSStream8_Online
Stage1_CentOSStream8_Offline_N-1SDK
Stage1_Fedora36_Offline
Stage2_Fedora36_Offline
CentOSStream8_Online
CentOSStream8_Offline_N-1_SDK
Fedora36_Offline
Fedora36_Offline_Rebuild or Fedora36_Offline_N_SDK
There was a problem hiding this comment.
More ideas after talking with some source-build folks
CentOSStream8_Online_MsftSdk
Fedora36_Offline_MsftSdk
Fedora36_Offline_CurrentSourceBuiltSdk
CentOSStream8_Offline_PreviousSourceBuiltSdk
CentOSStream8_Online_MsftSdk_Stage1
Fedora36_Offline_MsftSdk_Stage1
Fedora36_Offline_Stage1Sdk_Stage2
CentOSStream8_Offline_PreviousSourceBuiltSdk_Stage1
There was a problem hiding this comment.
Just a note - we'll need to update the release pipeline if these change
There was a problem hiding this comment.
@MichaelSimons we will now have to synchronize the list of legs between 3 places:
- VMR build
- SDK diff pipeline
- Release pipeline/checklist (if it needs to download the prereqs from a certain leg)
There was a problem hiding this comment.
I imagine this might become a point of friction
| # Temporarily move this to PR build just to test the N-1 CI | ||
| - template: ../jobs/vmr-build.yml | ||
| parameters: | ||
| buildName: CentOSStream8_WithPreviousSDK |
There was a problem hiding this comment.
More ideas after talking with some source-build folks
CentOSStream8_Online_MsftSdk
Fedora36_Offline_MsftSdk
Fedora36_Offline_CurrentSourceBuiltSdk
CentOSStream8_Offline_PreviousSourceBuiltSdk
CentOSStream8_Online_MsftSdk_Stage1
Fedora36_Offline_MsftSdk_Stage1
Fedora36_Offline_Stage1Sdk_Stage2
CentOSStream8_Offline_PreviousSourceBuiltSdk_Stage1
5 tasks
MichaelSimons
approved these changes
Mar 3, 2023
|
Next set of errors: As described before I am going to merge around this, as I think these errors come from incoherencies in the product and not any issue with the new CI leg. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#3220