Skip to content

Remove xliff-tasks source link mapping #4359

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
ViktorHofer opened this issue Oct 30, 2023 · 8 comments · Fixed by dotnet/sdk#48628
Closed

Remove xliff-tasks source link mapping #4359

ViktorHofer opened this issue Oct 30, 2023 · 8 comments · Fixed by dotnet/sdk#48628

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 30, 2023

Now that the xliff-tasks repo got merged into arcade and the xlifftasks.proj orchestrator project got deleted, we should delete the source-mapping for it to initialize the VMR and delete the sources from the VMR repo.

From what others mentioned, the source-mapping needs to stay until all nodes in the repo graph updated their Version.Details.xml entries and remove the xliff-tasks repo mention: https://github.com/search?q=repo%3Adotnet%2Fdotnet+xliff-tasks+path%3AVersion.Details.xml&type=code

@marcpopMSFT
Copy link
Member

@premun I see merged PRs linked. Can this be closed?

@ViktorHofer
Copy link
Member Author

No, this issue still tracks the removal of the source link mapping.

@ViktorHofer ViktorHofer transferred this issue from dotnet/installer Apr 26, 2024
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ViktorHofer
Copy link
Member Author

The source-mappings.json file still lists xliff-tasks.

@ViktorHofer
Copy link
Member Author

@premun there are two repos left that reference the xliff-tasks repo:

The aspire case is tricky. Would removing the entry in dotnet/dotnet allow us to remove the xliff-tasks entry in source-mapping.json and the folder in the VMR?

@premun
Copy link
Member

premun commented Apr 15, 2025

We cannot remove xliff-tasks because the dependency tree of SDK commits would still contain it and the tooling would not know what to do about it and fail. So no matter what you do in the VMR, the source-mappings won't match the real source code tree from outside of the VMR. We'd have to remove aspire from sdk's V.D.xml and remove xliff-tasks from the command-line-api V.D.xml.

But, is there any harm in having those in the file? We can remove these next week when we switch to the flat flow?

@ViktorHofer
Copy link
Member Author

The command-line-api one already got removed, it just needs to flow. That will happen this week.

But, is there any harm in having those in the file? We can remove these next week when we switch to the flat flow?

Last time when we talked about xliff-tasks in the sync, you mentioned that it would help removing it before we switch to flat flow. If that isn't the case anymore then I won't look further into this.

@ViktorHofer ViktorHofer removed their assignment Apr 15, 2025
@akoeplinger
Copy link
Member

just so I understand: we can still remove xliff-tasks from the VMR next week?

@github-project-automation github-project-automation bot moved this from Ready to Done in .NET Unified Build Apr 23, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants