-
Notifications
You must be signed in to change notification settings - Fork 134
Remove xliff-tasks source link mapping #4359
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
@premun I see merged PRs linked. Can this be closed? |
No, this issue still tracks the removal of the source link mapping. |
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
The source-mappings.json file still lists xliff-tasks. |
@premun there are two repos left that reference the xliff-tasks repo:
The aspire case is tricky. Would removing the entry in dotnet/dotnet allow us to remove the xliff-tasks entry in source-mapping.json and the folder in the VMR? |
We cannot remove But, is there any harm in having those in the file? We can remove these next week when we switch to the flat flow? |
The command-line-api one already got removed, it just needs to flow. That will happen this week.
Last time when we talked about xliff-tasks in the sync, you mentioned that it would help removing it before we switch to flat flow. If that isn't the case anymore then I won't look further into this. |
just so I understand: we can still remove xliff-tasks from the VMR next week? |
Now that the xliff-tasks repo got merged into arcade and the xlifftasks.proj orchestrator project got deleted, we should delete the source-mapping for it to initialize the VMR and delete the sources from the VMR repo.
From what others mentioned, the source-mapping needs to stay until all nodes in the repo graph updated their Version.Details.xml entries and remove the xliff-tasks repo mention: https://github.com/search?q=repo%3Adotnet%2Fdotnet+xliff-tasks+path%3AVersion.Details.xml&type=code
The text was updated successfully, but these errors were encountered: