-
Notifications
You must be signed in to change notification settings - Fork 134
Microsoft.TestPlatform and Microsoft.TestPlatform.Portable packages missing from VMR #4996
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Even though it might not matter, the package should get produced in VMR UB builds, just not in source-build: https://github.com/microsoft/vstest/blob/debb6b8de4f51c50aba52ca9fe5f559846f45cfb/src/package/Microsoft.TestPlatform.Portable/Microsoft.TestPlatform.Portable.csproj#L19-L20 Same for the other. |
Submitted dotnet/dotnet#171 to see if computer says yes. |
OK yeah we can't build those packages in the VMR because we depend on the LICENSE_VS file that is cloaked out in the VMR: https://github.com/microsoft/vstest/blob/main/src/package/licenses/LICENSE_VS.txt Could we exclude the license from the two packages, given that we don't publish them? @mmitche |
Perhaps this is what you meant, but rather than excluding a license, perhaps you could use the same open source license that source-build uses. |
Do those packages get referenced anywhere? Are you thinking to produce them just to be safe, or because they are needed? |
Yeah, it doesn't really matter. I felt like building the packages and reducing the asset diff between MSFT and VMR builds is the cleaner approach. |
but with the MIT license instead of VS. Fixes dotnet/source-build#4996
but with the MIT license instead of VS. Fixes dotnet/source-build#4996
The packages don't build successfully on non-Windows. Let's just baseline them. I'm not happy with the fact that the vstest repo is so Windows centric but it is what it is. |
The text was updated successfully, but these errors were encountered: