Skip to content

Microsoft.TestPlatform and Microsoft.TestPlatform.Portable packages missing from VMR #4996

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
ViktorHofer opened this issue Apr 2, 2025 · 7 comments · Fixed by microsoft/vstest#15055
Assignees

Comments

@ViktorHofer
Copy link
Member

    <AssetMapping Id="Microsoft.TestPlatform" Type="Package">
      <BaseFile>D:\a\_work\1\a\base-assets\vstest\shipping\packages\Microsoft.TestPlatform.17.14.0-preview-25181-02.nupkg</BaseFile>
      <EvaluationErrors />
      <Issues>
        <Issue Type="MissingShipping" Description="Package 'Microsoft.TestPlatform' is missing in the VMR." />
      </Issues>
    </AssetMapping>
    <AssetMapping Id="Microsoft.TestPlatform.Portable" Type="Package">
      <BaseFile>D:\a\_work\1\a\base-assets\vstest\shipping\packages\Microsoft.TestPlatform.Portable.17.14.0-preview-25181-02.nupkg</BaseFile>
      <EvaluationErrors />
      <Issues>
        <Issue Type="MissingShipping" Description="Package 'Microsoft.TestPlatform.Portable' is missing in the VMR." />
      </Issues>
    </AssetMapping>
    <AssetMapping Id="assets/symbols/Microsoft.TestPlatform.17.14.0-preview-25181-02.symbols.nupkg" Type="Blob">
      <BaseFile>D:\a\_work\1\a\base-assets\vstest\shipping\assets/symbols/Microsoft.TestPlatform.17.14.0-preview-25181-02.symbols.nupkg</BaseFile>
      <EvaluationErrors />
      <Issues>
        <Issue Type="MissingShipping" Description="Blob 'assets/symbols/Microsoft.TestPlatform.17.14.0-preview-25181-02.symbols.nupkg' is missing in the VMR." />
      </Issues>
    </AssetMapping>
    <AssetMapping Id="assets/symbols/Microsoft.TestPlatform.Portable.17.14.0-preview-25181-02.symbols.nupkg" Type="Blob">
      <BaseFile>D:\a\_work\1\a\base-assets\vstest\shipping\assets/symbols/Microsoft.TestPlatform.Portable.17.14.0-preview-25181-02.symbols.nupkg</BaseFile>
      <EvaluationErrors />
      <Issues>
        <Issue Type="MissingShipping" Description="Blob 'assets/symbols/Microsoft.TestPlatform.Portable.17.14.0-preview-25181-02.symbols.nupkg' is missing in the VMR." />
      </Issues>
    </AssetMapping>
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 2, 2025

Even though it might not matter, the package should get produced in VMR UB builds, just not in source-build: https://github.com/microsoft/vstest/blob/debb6b8de4f51c50aba52ca9fe5f559846f45cfb/src/package/Microsoft.TestPlatform.Portable/Microsoft.TestPlatform.Portable.csproj#L19-L20

Same for the other.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 2, 2025

Submitted dotnet/dotnet#171 to see if computer says yes.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 2, 2025

OK yeah we can't build those packages in the VMR because we depend on the LICENSE_VS file that is cloaked out in the VMR: https://github.com/microsoft/vstest/blob/main/src/package/licenses/LICENSE_VS.txt

Could we exclude the license from the two packages, given that we don't publish them? @mmitche
If the answer is no, then let's baseline the entries.

@MichaelSimons
Copy link
Member

Could we exclude the license from the two packages, given that we don't publish them?

Perhaps this is what you meant, but rather than excluding a license, perhaps you could use the same open source license that source-build uses.

@mmitche
Copy link
Member

mmitche commented Apr 2, 2025

Do those packages get referenced anywhere? Are you thinking to produce them just to be safe, or because they are needed?

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 2, 2025

Yeah, it doesn't really matter. I felt like building the packages and reducing the asset diff between MSFT and VMR builds is the cleaner approach.

@mmitche mmitche moved this to Ready in .NET Unified Build Apr 3, 2025
@ViktorHofer ViktorHofer moved this from Ready to In Progress in .NET Unified Build Apr 8, 2025
ViktorHofer added a commit to microsoft/vstest that referenced this issue Apr 18, 2025
but with the MIT license instead of VS.

Fixes dotnet/source-build#4996
nohwnd pushed a commit to microsoft/vstest that referenced this issue Apr 21, 2025
but with the MIT license instead of VS.

Fixes dotnet/source-build#4996
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 22, 2025

microsoft/vstest#15057

The packages don't build successfully on non-Windows. Let's just baseline them. I'm not happy with the fact that the vstest repo is so Windows centric but it is what it is.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants