Skip to content

Remove repo level source build CI/PR legs #5006

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
MichaelSimons opened this issue Apr 7, 2025 · 2 comments
Closed

Remove repo level source build CI/PR legs #5006

MichaelSimons opened this issue Apr 7, 2025 · 2 comments
Labels
area-unified-build Epic Groups multiple user stories. Can be grouped under a theme.

Comments

@MichaelSimons
Copy link
Member

Per the UB Validation Strategy, the repo level source build CI/PR legs should be removed. The basis for comes from the difficulty of validating source build, specifically correctly detecting prebuilts, at the repo level. Validating source build is best done in the VMR. Support will be added for optional VMR based source build legs in repo PR validation.

This epic tracts the removal of repo level source build CI/PR legs.

@ViktorHofer
Copy link
Member

For all these we should also remove conditions that apply only to the repo source-build: DotNetBuildSourceOnly==true && DotNetBuildOrchestrator!=true

@MichaelSimons
Copy link
Member Author

MichaelSimons commented Apr 22, 2025

In discussing this, there is value is leaving the SB PR/CI legs as a way to validate the SB infrastructure at the repo level. These legs should be considered optional. If a repo opts into enabling a VMR SB validation leg, then the repo level SB leg should be disabled as it would add no additional value. If a repo has no special source only conditions then it may make sense to disable the source build leg.

Closing as we will not being doing a mass removal.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area-unified-build Epic Groups multiple user stories. Can be grouped under a theme.
Projects
Status: Done
Development

No branches or pull requests

2 participants