Revert "update System.CommandLine (#1356)", but keep the removal of two dependencies #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3c34adc.
…mmandLine.NamingConventionBinder
ViktorHofer
approved these changes
Feb 6, 2025
adamsitnik
added a commit
to adamsitnik/sourcelink
that referenced
this pull request
Feb 6, 2025
…al of two dependencies (dotnet#1363) This reverts commit 3ce7edb.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3c34adc due to circular dependency between SDK and NuGet.Client that both use System.CommandLine. The update will be re-introduced around April.
But it keeps the changes responsible for removing dependencies to System.CommandLine.Rendering and System.CommandLine.NamingConventionBinder (we are not going to ship this libraries anymore and they were not used here so there is no point of keeping these dependencies).
cc @ViktorHofer