InitializeDisplayMemberPropertyDescriptor and InitializeValueMemberPropertyDescriptor give misleading error message

[mpolicki]

.NET version

9.0.102

Did it work in .NET Framework?

Not tested/verified

Did it work in any of the earlier releases of .NET Core or .NET 5+?

No response

Issue description

In DataGridViewComboBoxCell, the methods InitializeDisplayMemberPropertyDescriptor and InitializeValueMemberPropertyDescriptor throw ArgumentExceptions with the message SR.DataGridViewComboBoxCell_FieldNotFound.

winforms/src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridViewComboBoxCell.cs

Lines 1360 to 1362 in e2942ed

	if (displayMemberProperty is null)
	{
	throw new ArgumentException(string.Format(SR.DataGridViewComboBoxCell_FieldNotFound, displayMember));

winforms/src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridViewComboBoxCell.cs

Lines 1391 to 1393 in e2942ed

	if (valueMemberProperty is null)
	{
	throw new ArgumentException(string.Format(SR.DataGridViewComboBoxCell_FieldNotFound, valueMember));

I have not been able to find the source string for the message, but it is "Field called {0} does not exist.", with the appropriate substitution for "{0}".
It is my understanding that binding happens to properties, not fields, and thus the error message should say "Property called {0} does not exist.". The current error message is especially confusing to newcomers to data binding who try to bind to fields since it claims exactly the opposite of what's true (e.g. you try to bind to a field called Item1, and you get an error saying "Field called Item1 does not exist.").

Steps to reproduce

Create a new Windows Forms project and use the following code.

    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
            DataGridViewComboBoxColumn column = new();
            DataGridView dataGridView = new();
            FlowLayoutPanel flowLayoutPanel = new();
            Controls.Add(flowLayoutPanel);
            flowLayoutPanel.Controls.Add(dataGridView);
            dataGridView.Columns.Add(column);
            column.DataSource = new ValueTuple<string, int>[] { new("One", 1) };
            // The following line throws System.ArgumentException: 'Field called Item1 does not exist.'
            column.DisplayMember = nameof(ValueTuple<string, int>.Item1);
            column.ValueMember = nameof(ValueTuple<string, int>.Item2);
        }
    }

[Tanya-Solyanik]

Good point! I think this message refers to https://learn.microsoft.com/dotnet/api/system.windows.forms.bindingmemberinfo.bindingfield?view=windowsdesktop-9.0, but we are actually searching for a property with the given name.

[merriemcgaw]

@LeafShi1 / @ricardobossan can you please update the string to reflect "property"? We've confirmed that "property" is the right value.

[Olina-Zhang]

Verified in the latest .NET 10 SDK build: 10.0.100-preview.2.25105.6, it was fixed: now the error message for displayMenber and valueMember of dataGridViewComboBoxColumn uses property string:

[Syareel-Sukeri]

Verified with .NET SDK 10.0 P1 test pass build, it was fixed as above testing result.