-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Convert Rest of Ole to Cswin32 #10651
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10651 +/- ##
===================================================
- Coverage 72.62818% 72.62715% -0.00104%
===================================================
Files 2896 2896
Lines 622253 622354 +101
Branches 46997 47009 +12
===================================================
+ Hits 451931 451998 +67
- Misses 161993 162032 +39
+ Partials 8329 8324 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
@kant2002 are you still interested in Winforms Clipboard interop for AOT? |
I think that this is valuable, but i do not have capacity for this work unfortunately. Anything else I can help with? |
Just keeping you informed. |
I have fetched your branch and initial testing of drag and drop looks good to me. |
Thanks! Appreciate the extra eyes (: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@@ -5198,12 +5198,44 @@ public DragDropEffects DoDragDrop(object data, DragDropEffects allowedEffects) | |||
/// value. | |||
/// </para> | |||
/// </remarks> | |||
public DragDropEffects DoDragDrop( | |||
public unsafe DragDropEffects DoDragDrop( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the Control is unsafe
this isn't necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice catch! I'll address this in a follow up
System.Runtime.InteropServices.ComTypes.IDataObject
to be taken as is. If it does not, we will wrap the data in aDataObject
System.Windows.Forms.IDataObject
to be passed out as is. If it does not, we will wrap the data in aDataObject
Microsoft Reviewers: Open in CodeFlow