Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Convert Rest of Ole to Cswin32 #10651

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Convert Rest of Ole to Cswin32 #10651

merged 5 commits into from
Jan 18, 2024

Conversation

lonitra
Copy link
Member

@lonitra lonitra commented Jan 12, 2024

  • Adds test to capture our wrapping behavior:
    • Data coming in must implement System.Runtime.InteropServices.ComTypes.IDataObject to be taken as is. If it does not, we will wrap the data in a DataObject
    • Data going out must implement System.Windows.Forms.IDataObject to be passed out as is. If it does not, we will wrap the data in a DataObject
  • Convert the remaining ole functions to Cswin32
  • Other minor clean ups
  • Add test capturing clipboard proxy behavior
Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned lonitra Jan 12, 2024
@lonitra lonitra added the draft draft PR label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (4394995) 72.62818% compared to head (c35aab3) 72.62715%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10651         +/-   ##
===================================================
- Coverage   72.62818%   72.62715%   -0.00104%     
===================================================
  Files           2896        2896                 
  Lines         622253      622354        +101     
  Branches       46997       47009         +12     
===================================================
+ Hits          451931      451998         +67     
- Misses        161993      162032         +39     
+ Partials        8329        8324          -5     
Flag Coverage Δ
Debug 72.62715% <46.44550%> (-0.00104%) ⬇️
production 43.46451% <33.64486%> (+0.00300%) ⬆️
test 97.33942% <59.61538%> (-0.01170%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@elachlan
Copy link
Contributor

@kant2002 are you still interested in Winforms Clipboard interop for AOT?

@kant2002
Copy link
Contributor

I think that this is valuable, but i do not have capacity for this work unfortunately. Anything else I can help with?

@elachlan
Copy link
Contributor

Just keeping you informed.

@willibrandon
Copy link
Contributor

I have fetched your branch and initial testing of drag and drop looks good to me.

@lonitra
Copy link
Member Author

lonitra commented Jan 18, 2024

I have fetched your branch and initial testing of drag and drop looks good to me.

Thanks! Appreciate the extra eyes (:

@lonitra lonitra marked this pull request as ready for review January 18, 2024 17:40
@lonitra lonitra requested a review from a team as a code owner January 18, 2024 17:40
@lonitra lonitra removed the draft draft PR label Jan 18, 2024
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@@ -5198,12 +5198,44 @@ public DragDropEffects DoDragDrop(object data, DragDropEffects allowedEffects)
/// value.
/// </para>
/// </remarks>
public DragDropEffects DoDragDrop(
public unsafe DragDropEffects DoDragDrop(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the Control is unsafe this isn't necessary

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice catch! I'll address this in a follow up

@lonitra lonitra merged commit 64528f3 into dotnet:main Jan 18, 2024
9 checks passed
@lonitra lonitra deleted the ole branch January 18, 2024 22:09
@ghost ghost added this to the 9.0 Preview1 milestone Jan 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants