Enable NuGet Audit and Fix Errors #12120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonitra
commented
Sep 11, 2024
| </PropertyGroup> | ||
| <!-- Additional unchanging dependencies --> | ||
| <PropertyGroup> | ||
| <MicrosoftTargetingPackNETFrameworkv472PackageVersion>1.0.0</MicrosoftTargetingPackNETFrameworkv472PackageVersion> | ||
| <MicrosoftWindowsDesktopAppRefv30PackageVersion>3.0.0</MicrosoftWindowsDesktopAppRefv30PackageVersion> | ||
| <NewtonsoftJsonVersion>13.0.1</NewtonsoftJsonVersion> | ||
| <VsWherePackageVersion>2.6.7</VsWherePackageVersion> | ||
| <!-- Pin transitive dependency to avoid vulnerable 8.0.0 version. --> | ||
| <SystemFormatsAsn1PackageVersion>8.0.1</SystemFormatsAsn1PackageVersion> |
There was a problem hiding this comment.
Created issue to track unpinning this #12121
28 tasks
lonitra
commented
Sep 11, 2024
| [WinFormsFact] | ||
| public void Dispose_Invoke_CallsDisposeDisposing() | ||
| { | ||
| Mock<ApplicationContext> mockContext = new(MockBehavior.Strict); | ||
| mockContext |
There was a problem hiding this comment.
With the upgrade to latest moq version, I get errors with moq complaining that there is no protected Dispose(bool) method even though there is. I have opted to avoiding mocking a test object and creating a real test object instead or just removing the Dispose setup if it doesn't look to be necessary.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12120 +/- ##
===================================================
+ Coverage 75.21471% 75.22675% +0.01203%
===================================================
Files 3076 3079 +3
Lines 633053 633195 +142
Branches 46814 46817 +3
===================================================
+ Hits 476149 476332 +183
+ Misses 153517 153465 -52
- Partials 3387 3398 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tanya-Solyanik
approved these changes
Sep 11, 2024
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: dotnet/arcade#15019
Microsoft Reviewers: Open in CodeFlow