Skip to content

Fix a series of Analyzer issues (backport from release/net9). #13333

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann commented Apr 21, 2025

Forward port of .NET 9 Analyzer Fixes.

Note: This PR bring over the fixes, NOT the test infrastructure at this point.
We want the fixes of the following issues have in as early as possible for more time to test with real bits out.

Note also, that this PR will NOT close these issues.
They remain open until we're services release/net9.

Microsoft Reviewers: Open in CodeFlow

@KlausLoeffelmann KlausLoeffelmann requested a review from a team as a code owner April 21, 2025 23:56
@github-actions github-actions bot added the area-Analyzers/CodeFixes A Roslyn Analyzer is either needed for the context, needs to be scope extended or fixed. label Apr 21, 2025
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 30.95238% with 29 lines in your changes missing coverage. Please review.

Project coverage is 62.57036%. Comparing base (7098151) to head (720bc29).
Report is 4 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13333         +/-   ##
===================================================
- Coverage   62.57851%   62.57036%   -0.00816%     
===================================================
  Files           1560        1560                 
  Lines         159689      159721         +32     
  Branches       14906       14915          +9     
===================================================
+ Hits           99931       99938          +7     
- Misses         58988       59009         +21     
- Partials         770         774          +4     
Flag Coverage Δ
Debug 62.57036% <30.95238%> (-0.00816%) ⬇️
integration 11.32378% <ø> (+0.00523%) ⬆️
production 40.75928% <30.95238%> (-0.00629%) ⬇️
test 95.69057% <ø> (ø)
unit 38.14355% <30.95238%> (-0.00645%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KlausLoeffelmann KlausLoeffelmann added 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) and removed 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) labels Apr 22, 2025
@KlausLoeffelmann KlausLoeffelmann merged commit 99b335c into dotnet:main Apr 22, 2025
8 checks passed
@KlausLoeffelmann KlausLoeffelmann deleted the FixAnalyzersPreview branch April 22, 2025 07:20
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview4 milestone Apr 22, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area-Analyzers/CodeFixes A Roslyn Analyzer is either needed for the context, needs to be scope extended or fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants