Skip to content

[Release/9.0] Fix false-positive WinForms Analyzer diagnostics. #13411

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann commented May 5, 2025

Fixes #13160.
We're servicing only the false-positive WinForms Analyzers edge cases for low-risk servicing.

Microsoft Reviewers: Open in CodeFlow

@KlausLoeffelmann KlausLoeffelmann requested a review from a team as a code owner May 5, 2025 21:04
@Tanya-Solyanik Tanya-Solyanik changed the title [Release/Net9] Fix false-positive WinForms Analyzer diagnostics. [Release/9.0] Fix false-positive WinForms Analyzer diagnostics. May 5, 2025
Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 74.83965%. Comparing base (4a9a9f0) to head (133e570).
Report is 6 commits behind head on release/9.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           release/9.0      #13411          +/-   ##
======================================================
+ Coverage     44.90473%   74.83965%   +29.93492%     
======================================================
  Files             1956        3022        +1066     
  Lines           284391      630480      +346089     
  Branches         41754       46806        +5052     
======================================================
+ Hits            127705      471849      +344144     
- Misses          149047      155242        +6195     
+ Partials          7639        3389        -4250     
Flag Coverage Δ
Debug 74.83965% <41.66667%> (+29.93492%) ⬆️
integration 18.02233% <ø> (?)
production 47.87435% <41.66667%> (+2.96961%) ⬆️
test 97.00005% <ø> (?)
unit 44.90677% <41.66667%> (+0.00204%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label May 7, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label May 7, 2025
@KlausLoeffelmann KlausLoeffelmann added 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria labels May 7, 2025
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik added servicing-approved .NET Shiproom approved the PR for merge and removed servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria labels May 8, 2025
@Tanya-Solyanik Tanya-Solyanik added this to the 9.0.6 milestone May 8, 2025
@KlausLoeffelmann KlausLoeffelmann merged commit fe592d7 into dotnet:release/9.0 May 8, 2025
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) servicing-approved .NET Shiproom approved the PR for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants