Remove MarshalLocal proxy for IsTypeVisibleFromCom (#9609)

dotnet · Oct 8, 2024 · f07e041 · f07e041
1 parent f4b5926
commit f07e041
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 20 deletions.
diff --git a/src/Microsoft.DotNet.Wpf/src/PresentationFramework/MarshalLocal.cs b/src/Microsoft.DotNet.Wpf/src/PresentationFramework/MarshalLocal.cs
diff --git a/src/Microsoft.DotNet.Wpf/src/PresentationFramework/PresentationFramework.csproj b/src/Microsoft.DotNet.Wpf/src/PresentationFramework/PresentationFramework.csproj
@@ -62,7 +62,6 @@
     <Compile Include="$(WpfSharedDir)\Telemetry\Managed\TelemetryEventSource.cs" />
     <Compile Include="$(WpfSharedDir)\Telemetry\Managed\TraceLoggingProvider.cs" />
     <Compile Include="$(WpfSharedDir)\Telemetry\Managed\TraceLoggers\ControlsTraceLogger.cs" />
-    <Compile Include="MarshalLocal.cs" />
     <Compile Include="Microsoft\Win32\CommonDialog.cs" />
     <Compile Include="Microsoft\Win32\CommonItemDialog.cs" />
     <Compile Include="Microsoft\Win32\FileDialog.cs" />

diff --git a/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Controls/WebBrowser.cs b/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Controls/WebBrowser.cs
@@ -436,7 +436,7 @@ public object ObjectForScripting
                 {
                     Type t = value.GetType();
 
-                    if (!System.Runtime.InteropServices.MarshalLocal.IsTypeVisibleFromCom(t))
+                    if (!Marshal.IsTypeVisibleFromCom(t))
                     {
                         throw new ArgumentException(SR.NeedToBeComVisible);
                     }

diff --git a/...rosoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Interop/DynamicScriptObject.cs b/...rosoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Interop/DynamicScriptObject.cs
@@ -285,8 +285,7 @@ internal unsafe bool TryFindMemberAndInvokeNonWrapped(string memberName, int fla
             // model, we rather throw instead. This Try-method allows internal lookups without directly
             // throwing on non-fatal "member not found" situations, as we might want to have more complex
             // fallback logic (as in ToString).
-            int dispid;
-            if (!TryGetDispIdForMember(memberName, cacheDispId, out dispid))
+            if (!TryGetDispIdForMember(memberName, cacheDispId, out int dispId))
             {
                 return false;
             }
@@ -358,7 +357,7 @@ internal unsafe bool TryFindMemberAndInvokeNonWrapped(string memberName, int fla
                             // by the CLR. Therefore we also check for the IsCOMObject property. It also seems
                             // COM interop special-cases DateTime as it's not revealed to be visible by any
                             // of the first two checks below.
-                            if (!MarshalLocal.IsTypeVisibleFromCom(argType) && 
+                            if (!Marshal.IsTypeVisibleFromCom(argType) && 
                                 !argType.IsCOMObject && argType != typeof(DateTime))
                             {
                                 throw new ArgumentException(SR.NeedToBeComVisible);
@@ -371,7 +370,7 @@ internal unsafe bool TryFindMemberAndInvokeNonWrapped(string memberName, int fla
                 }
 
                 NativeMethods.EXCEPINFO exInfo = new NativeMethods.EXCEPINFO();
-                HRESULT hr = InvokeOnScriptObject(dispid, flags, dp, exInfo, out result);
+                HRESULT hr = InvokeOnScriptObject(dispId, flags, dp, exInfo, out result);
 
                 if (hr.Failed)
                 {