[StyleCleanUp] Addressing CA warnings Part 1 #10128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
the
PR
|
The changes in this PR will be included in another PR. |
lindexi
reviewed
Dec 5, 2024
| @@ -483,7 +483,7 @@ private void Initialize(FileUnit sourceFile) | |||
| } | |||
|
|
|||
| int pathEndIndex = SourceFileInfo.RelativeSourceFilePath.LastIndexOf(Path.DirectorySeparatorChar); | |||
| string targetPath = string.Concat(TargetPath, SourceFileInfo.RelativeSourceFilePath.AsSpan(0, pathEndIndex + 1)); | |||
| string targetPath = string.Concat(TargetPath, SourceFileInfo.RelativeSourceFilePath.Substring(0, pathEndIndex + 1)); | |||
There was a problem hiding this comment.
Why we back to Substring here? Will it cause the warning?
There was a problem hiding this comment.
Actually, it wasn't raising a warning, so the change was unnecessary.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work is a part of our initiative to set code-style guidelines, align WPF and WinForms, and ensure PR standards with respect to styles. This in turn will help us in better maintainability and readability of the repo overall. The changes follow up from the PR #10080 and references to the issue #10017.
The current changes address the following Errors/Warnings in the src folder of WPF:
A good way to go about reviewing this is to go commit by commit which pans over individual errors/warnings and hence easing out the overall understanding.
Customer Impact
None
Regression
None
Testing
Local Build Pass
The current set of changes looks fairly mechanical and probably don't need a Test Pass, but these set of PRs can be clubbed to do so at a later stage.
Risk
Low
Microsoft Reviewers: Open in CodeFlow