[.NET 9 ] Fluent Style Fixes : HC.xaml loading, disabled radiobutton UI etc. #10133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
the
PR
harshit7962
approved these changes
Dec 3, 2024
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
microsoft/WPF-Samples#673
#10054 , #10043
Main PR
#10094 , #10129 , #10116 , #10132
Description
In this PR, I have backported the fixes from other Fluent style fixing PRs which need to go in .NET 9. It includes the following :
Customer Impact
Developers will be able to use HighContrast mode, use color resource keys without issues and will receive correct UI for RadioButton. For developers who want to customize TabControl and TabItem deafult styles will be able to now do it without redefining the complete style.
Regression
Yes, first three of the above are regressions.
Testing
Local testing with sample apps + Unit testing
Risk
Minimal. None of the originally available resource keys are removed. A few resources have been added.
Microsoft Reviewers: Open in CodeFlow