Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Cleanup] Use named arguments in WindowsBase #10215

Conversation

ThomasGoulet73
Copy link
Contributor

@ThomasGoulet73 ThomasGoulet73 commented Dec 30, 2024

Contributes to #10018

Description

I replaced comments specifying an argument name with named arguments, which were introduced in C# 7. This improves readability and maintainability.

My changes are in 2 commits the first commit is automated changes using regexes and the second commit is manual changes where the comment is outdated or formatted differently than the parameter name.

Note: The compiled IL is identical.

Customer Impact

None.

Regression

No.

Testing

Local build + validated IL.

Risk

Low to none.

Microsoft Reviewers: Open in CodeFlow

@ThomasGoulet73 ThomasGoulet73 requested review from a team as code owners December 30, 2024 22:20
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Dec 30, 2024
@pchaurasia14 pchaurasia14 merged commit 5606291 into dotnet:main Jan 3, 2025
8 checks passed
@pchaurasia14
Copy link
Member

Thanks @ThomasGoulet73 !

@ThomasGoulet73
Copy link
Contributor Author

Thanks

@ThomasGoulet73 ThomasGoulet73 deleted the cleanup-use-named-arguments-in-WindowsBase branch January 3, 2025 20:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants