Skip to content

[StyleCleanUp] Fix MilCodeGen license header #10702

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

ThomasGoulet73
Copy link
Contributor

@ThomasGoulet73 ThomasGoulet73 commented Apr 4, 2025

Description

Most of the generated files were changed in #10372, this PR syncs MilCodeGen to the current generated code to avoid unnecessary diffs when running MilCodeGen.

This PR also reverts whitespace line changes from #10021 that made the generated files out of sync with MilCodeGen. EDIT: Reverted in this PR and fixed in #10762.

Customer Impact

None, code style only.

Regression

No.

Testing

Local build + running MilCodeGen

Risk

Low to none.

Microsoft Reviewers: Open in CodeFlow

@ThomasGoulet73 ThomasGoulet73 requested review from a team as code owners April 4, 2025 03:52
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Apr 4, 2025
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.66982%. Comparing base (2ded801) to head (cda061c).
Report is 29 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10702         +/-   ##
===================================================
+ Coverage   10.95887%   12.66982%   +1.71095%     
===================================================
  Files           3310        3316          +6     
  Lines         664667      665321        +654     
  Branches       74667       74667                 
===================================================
+ Hits           72840       84295      +11455     
+ Misses        590685      578819      -11866     
- Partials        1142        2207       +1065     
Flag Coverage Δ
Debug 12.66982% <ø> (+1.71095%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siagupta0202 siagupta0202 self-assigned this Apr 4, 2025
@siagupta0202 siagupta0202 merged commit 7f4f566 into dotnet:main Apr 13, 2025
8 checks passed
@siagupta0202
Copy link
Contributor

@ThomasGoulet73 Thank you for your contribution!

@ThomasGoulet73 ThomasGoulet73 deleted the StyleCleanUp-fix-MilCodeGen-license-header branch April 19, 2025 03:06
@ThomasGoulet73
Copy link
Contributor Author

Thanks @siagupta0202

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants