[StyleCleanUp] Specify StringComparison for correctness (CA1310) #10704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
h3xds1nz
commented
Apr 4, 2025
| { | ||
| return String.Compare(one.Key.ToString(), two.Key.ToString()); | ||
| return string.Compare(one.Key.ToString(), two.Key.ToString(), StringComparison.Ordinal); |
There was a problem hiding this comment.
This is a bit I'm not sure about changing to Ordinal. I don't think it matters in this case but it's something to keep in mind during review.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10704 +/- ##
===================================================
- Coverage 10.95887% 10.90897% -0.04990%
===================================================
Files 3310 3310
Lines 664667 664664 -3
Branches 74667 74667
===================================================
- Hits 72840 72508 -332
- Misses 590685 591024 +339
+ Partials 1142 1132 -10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10703
Description
Fixes culture-specific comparisons for compares that are not meant to be culture-specific (e.g. namespace names).
Customer Impact
Cleaner codebase for developers, deterministic output of some functions.
Regression
No.
Testing
Local build.
Risk
None but also medium (see self-review note).
Microsoft Reviewers: Open in CodeFlow