-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Replace occurrences of params T[] with params ReadOnlySpan<T> where possible #9481
base: main
Are you sure you want to change the base?
Conversation
714abef
to
1217ef8
Compare
I have fixed the merge conflict and rebased. |
…pan<InputGesture>
…eadOnlySpan<DependencyObject>
1217ef8
to
10775f7
Compare
Resolved merge conflicts 09 |
/// <remarks>THIS IS A SHARED FILE. PresentationFramework.Design.dll must be rebuilt if changed.</remarks> | ||
/// </summary> | ||
/// <summary> Names and helpers for visual states in the controls. </summary> | ||
/// <remarks> THIS IS A SHARED FILE: PresentationFramework.Design.dll must be rebuilt if changed. </remarks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PresentationFramework.Design.dll looks like something, I will have to take a look at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dipeshmsft There used to be PresentationFramework.VisualStudio.Design.dll
with old VS (e.g. my 2010 installation has it) as a private assembly (it was providing the design-time support afaik?). But the new ones don't have it as the whole designer has changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, if you find the remarks irrelevant (which I'm very much confident it is these days), then I'd remove it in this PR before merging it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dipeshmsft Any news?
Description
Continues the journey that started in #9468 and converts some internal call-chains from
params T[]
toparams ReadOnlySpan<T>
where I felt it is without any side-effects, largely decreasing allocations in other scenarios besides just tracing and improving both performance and allocations since we do not need to create a new heap array ofT[]
everytime.Simple benchmark with 0, 1, and 3 params
Benchmark code
Customer Impact
Improved performance, decreased allocations.
Regression
No.
Testing
Local build, test app run.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow