-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use string.Equals over string.Compare in ContentType for improved performance #9724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
September 5, 2024 19:51
dotnet-policy-service
bot
added
PR
metadata: Label to tag PRs, to facilitate with triage
Community Contribution
A label for all community Contributions
labels
Sep 5, 2024
CI failure caused by #9632 requesting |
Reference: #7836 I forgot about the subsequent optimization... |
Now it shall be complete haha. |
Good job |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
LGTM |
siagupta0202
approved these changes
Oct 1, 2024
@h3xds1nz Thank you for your contributions. |
@harshit7962 Thank you for including them. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Labels
Community Contribution
A label for all community Contributions
PR
metadata: Label to tag PRs, to facilitate with triage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces two uses of
string.Compare
inContentType
which is used for equality check withstring.Equals
.Difference in the last character
Difference in 5th character
Benchmark source strings
Customer Impact
Improved performance.
Regression
No.
Testing
Local build.
Risk
None, you can't ruin anything with this swap.
Microsoft Reviewers: Open in CodeFlow