Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove obsolete TARGETTING35SP1 preprocessor directive and dead code within #9744

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

h3xds1nz
Copy link
Contributor

@h3xds1nz h3xds1nz commented Sep 8, 2024

Description

Removes obsolete TARGETTING35SP1 preprocessor directive used in System.Xaml and removes the essentially dead code within those blocks (implementation of Lazy<T> came with net4 and more up-to-date WeakDictionary is in MS.Internal).

Customer Impact

None, just cleaner codebase.

Regression

No.

Testing

Local build.

Risk

None, just removes dead code.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners September 8, 2024 11:53
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Sep 8, 2024
@dipeshmsft
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dipeshmsft dipeshmsft self-assigned this Oct 1, 2024
@dipeshmsft dipeshmsft merged commit a08882f into dotnet:main Oct 8, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants