Replace ArrayList with List<GlyphRun> in PtsHost for performance/code quality #9870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
siagupta0202
approved these changes
Oct 14, 2024
|
@h3xds1nz Thank you very much for your contributions. |
|
@harshit7962 Happy to contribute. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces
ArrayListwithList<GlyphRun>to function as a temporary array. Improves code quality by swapping to generic collection. Also makesAddGlyphRunRecursivefunction static as it does not use any instance members.Sample benchmark showing difference between
ArrayListandList<T>with reference type can be found f.e. in #9432.Customer Impact
Improved performance, getting rid of
ArrayList.Regression
No.
Testing
Local build.
Risk
None, changes are minimal.
Microsoft Reviewers: Open in CodeFlow