Fix RemoveWriterByIndex bug, replace ArrayList in BitmapMetadataBlockWriter #9871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
h3xds1nz
force-pushed
the
replace-arraylist-bitmapmetadata
branch
from
0c4aa52 to
7d24ae2
Compare
h3xds1nz
commented
Oct 1, 2024
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Imaging/BitmapMetadata.cs
Show resolved
Hide resolved
h3xds1nz
changed the title
harshit7962
added
Status:InProgress
Status:Proposed
Included in test pass
Status:Completed
and removed
Status:InProgress
Status:Proposed
labels
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces backing
ArrayListinBitmapMetadataBlockWriterandBitmapMetadataBlockWriterEnumerator.Also fixes a bug in
RemoveWriterByIndexfunction, which would previously not remove the writer.Sample benchmark showing difference between
ArrayListandList<T>with reference type can be found f.e. in #9432.Customer Impact
Improved performance, decreased allocations, a bug fix.
Regression
No.
Testing
Local build, work with
BitmapMetadata.Risk
Low but note that things might actually work properly and a bit faster now.
Microsoft Reviewers: Open in CodeFlow