Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using this library with pleasure in our software. Unfortunately a user of ours turned up with a gpx which contained empty segments at the end which caused an error.
E.g. something like
When adding the segment to the track, the
update_meta_data
function barfed. My first solution was to only try to update the meta data if the segment actually contained points, but then the track also had empty segments, and not sure what the effects might be later on, so upon adding the segment I check if the segment actually contains points and only add in that case.I added an example-file + test-case. This should have no effect imho for anybody else, it would just handle ill-formed gpx files better (well maybe ill-formed is worded too strong: but gpx files with empty segments).