Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[WIP] Release prep #9

Closed
wants to merge 30 commits into from
Closed

[WIP] Release prep #9

wants to merge 30 commits into from

Conversation

fgrehm
Copy link
Contributor

@fgrehm fgrehm commented May 2, 2016

This PR introduces a RubyGem package for Vital and drops middleman for our main assets build process (it is only used to build the website / docs for the framework), Sass variables were also updated so that they are set as !defaults

TODO

  • Separate website from assets to be distributed
  • Support for font-url (get from twbs / fontawesome)
  • Gem package with support for rails
  • Task for rebuilding font icons
  • Fine tune what gets included on the gem package (no website nor raw icons)
  • Rake task to prepare package for a "tarball release"
  • Social share icons? not needed
  • Find a way to reference the components page from rails apps
  • Sample app to act as a live demo of rails integration
  • Automatically upload tarballs to github
  • Update docs
  • Revert font naming from vital-icons to icons
  • Update file size in documentations site
  • Update documentation to reflect /website/ to run documentation server

fgrehm added 26 commits April 29, 2016 02:33
@fgrehm fgrehm changed the title Release prep [WIP] Release prep May 2, 2016
.icon-vital:before
content: "\f101"

$font-vital-icons-icon-arrow-updown: ""
Copy link
Contributor

@bodytaing bodytaing May 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use the character set "/foo" etc. Some encoding output issues?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this might come from the sed we run to tweak font urls 💭

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually caused by sass / sass-convert and I believe is related to sass/sass#1395 😞 I found a way around it by digging through those comments and related issues but unfortunately I closed the tab that has the fix after getting it in place for this project so I can't give you a link with more info on it 🐼

Fix for this is the not so pretty 080f50a

@bodytaing
Copy link
Contributor

bodytaing commented May 2, 2016

👍 Lots of great work here @fgrehm. I'll jump in and make some small changes in addition to updating the docs. We can probably forego the inclusion social icons - want to leave this up to the implementer that will use Vital.

This was referenced May 11, 2016
@brupm
Copy link
Member

brupm commented May 11, 2016

@jeyb

@fgrehm
Copy link
Contributor Author

fgrehm commented Aug 5, 2016

Closing this in favor of all the other smaller PRs I sent out along the way:

@fgrehm fgrehm closed this Aug 5, 2016
@fgrehm fgrehm deleted the release-prep branch August 5, 2016 20:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants