-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[WIP] Release prep #9
Conversation
…te the components page later)
.icon-vital:before | ||
content: "\f101" | ||
|
||
$font-vital-icons-icon-arrow-updown: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use the character set "/foo" etc. Some encoding output issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this might come from the sed
we run to tweak font urls 💭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually caused by sass / sass-convert and I believe is related to sass/sass#1395 😞 I found a way around it by digging through those comments and related issues but unfortunately I closed the tab that has the fix after getting it in place for this project so I can't give you a link with more info on it 🐼
Fix for this is the not so pretty 080f50a
👍 Lots of great work here @fgrehm. I'll jump in and make some small changes in addition to updating the docs. We can probably forego the inclusion social icons - want to leave this up to the implementer that will use Vital. |
Closing this in favor of all the other smaller PRs I sent out along the way: |
This PR introduces a RubyGem package for Vital and drops middleman for our main assets build process (it is only used to build the website / docs for the framework), Sass variables were also updated so that they are set as
!default
sTODO
font-url
(get from twbs / fontawesome)Social share icons?not neededvital-icons
toicons
/website/
to run documentation server