fix: allocate collections in bump allocator #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Feb 21, 2024
| }); | ||
| writer.write("));").newLine(); | ||
| writer.writeLine("let comments_ref = comments.as_ref().map(|t| unsafe { mem::transmute::<&CommentContainer, &'a CommentContainer<'a>>(t) });"); | ||
| writer.writeLine(`let ast_view = ${getViewForFunctionName("Module")}(info_ref, tokens_ref, comments_ref, bump_ref);`); |
There was a problem hiding this comment.
This is pretty bad. I will do a followup to remove all these transmutes and clean this up.
dsherret
added a commit
that referenced
this pull request
Feb 21, 2024
Fixes a memory leak where collections weren't being deallocated. Co-authored-by: irbull irbull@users.noreply.github.com
dsherret
added a commit
that referenced
this pull request
Feb 21, 2024
Fixes a memory leak where collections weren't being deallocated. Co-authored-by: irbull <irbull@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak where collections weren't being deallocated.
Many thanks to @irbull for investigating and tracking down this issue!
Co-authored-by: irbull irbull@users.noreply.github.com