Adds Image faker #21
Merged
Adds Image faker #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drager
reviewed
Mar 13, 2020
|
@igorgoncalves Thanks a lot! I had a thought that instead of passing a comma separated string for the keywords we could actually accept a List of strings e.g: |
|
Make sense to me, I will change that :D |
|
Great, thanks! |
Co-Authored-By: Jesper Håkansson <jesper@jesperh.se>
This was referenced Mar 18, 2020
drager
reviewed
Apr 2, 2020
| new RegExp(r'^([A-Za-z0-9].+,[A-Za-z0-9]+)$|^([A-Za-z0-9]+)$'); | ||
| if (keywordFormat.hasMatch(keywords)) { | ||
| url += '?' + keywords; | ||
| new RegExp(r'^([A-Za-z0-9].+,[A-Za-z0-9]+)$|^([A-Za-z0-9]+)$'); |
There was a problem hiding this comment.
Please run dart formatter on this file.
Closed
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Resolve issue #19
Testing and Review Notes
Generates a url to a image random image. The size of image is determined by
widthandheightparamters. You can choose the image categories related by thekeywordsparameter separeted by comma .Example:
Result: https://source.unsplash.com/1200x900?nature,people
To Do