Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: fixed Token-Permissions for Actions #3517

Merged
merged 1 commit into from
Sep 18, 2024
Merged

chore: fixed Token-Permissions for Actions #3517

merged 1 commit into from
Sep 18, 2024

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Sep 18, 2024

Description

Related Issue

#3441

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Sep 18, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Sep 18, 2024
@gaius-qi gaius-qi self-assigned this Sep 18, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner September 18, 2024 07:48
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.78%. Comparing base (608b6a2) to head (bde5307).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3517      +/-   ##
==========================================
- Coverage   51.80%   51.78%   -0.02%     
==========================================
  Files         190      190              
  Lines       20377    20377              
==========================================
- Hits        10556    10552       -4     
- Misses       9016     9019       +3     
- Partials      805      806       +1     
Flag Coverage Δ
unittests 51.78% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@jim3ma jim3ma merged commit ae9f8df into main Sep 18, 2024
29 checks passed
@jim3ma jim3ma deleted the feature/token branch September 18, 2024 08:34
Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants