feat: optimize implement of the sync peers #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaius-qi
force-pushed
the
feature/sync-peers
branch
2 times, most recently
from
8a1941e to
0a2873b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3677 +/- ##
==========================================
- Coverage 35.50% 35.45% -0.05%
==========================================
Files 336 335 -1
Lines 37657 37617 -40
==========================================
- Hits 13369 13337 -32
+ Misses 23461 23457 -4
+ Partials 827 823 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gaius-qi
force-pushed
the
feature/sync-peers
branch
from
0a2873b to
b809422
Compare
gaius-qi
force-pushed
the
feature/sync-peers
branch
2 times, most recently
from
0b273ad to
1a855da
Compare
gaius-qi
force-pushed
the
feature/sync-peers
branch
2 times, most recently
from
af40d1a to
3a0ba1f
Compare
Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi
force-pushed
the
feature/sync-peers
branch
from
3a0ba1f to
da3184a
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes significant changes to the synchronization of peer information in the
managerpackage, specifically focusing on improving the sync process and validation. The most important changes include updating the peer sync logic, adding validation for theBatchSizeparameter, and modifying related tests.Improvements to peer synchronization:
manager/job/sync_peers.go: Refactored theSyncPeersinterface and related methods to make the sync operation synchronous, ensuring no concurrent sync jobs run simultaneously. The new logic merges sync peer results with the database and handles batch operations more efficiently. [1] [2] [3]Validation enhancements:
manager/config/config.go: Added validation to ensureBatchSizeis not zero in theValidatemethod and updated theSyncPeersConfigstruct to clarify the purpose of theBatchSizefield. [1] [2]Test updates:
manager/config/config_test.go: Updated tests to include validation for theBatchSizeparameter and ensure proper configuration loading. [1] [2]Configuration updates:
manager/config/constants.go: Updated the description of the default batch size constant to reflect its dual purpose for syncing peers and database operations.manager/config/testdata/manager.yaml: Added thebatchSizeparameter to thesyncPeersconfiguration in the test data.These changes enhance the robustness and efficiency of the peer synchronization process and ensure proper configuration validation.
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist