Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add is_default to SchedulerCluster table #458

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Add is_default to SchedulerCluster table

Related Issue

Motivation and Context

Fixes #456

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Jul 12, 2021
@gaius-qi gaius-qi self-assigned this Jul 12, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner July 12, 2021 13:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #458 (4719bc0) into main (b7b4558) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   36.31%   36.18%   -0.14%     
==========================================
  Files          85       85              
  Lines        6727     6727              
==========================================
- Hits         2443     2434       -9     
- Misses       3933     3943      +10     
+ Partials      351      350       -1     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 36.18% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 54.77% <0.00%> (-2.21%) ⬇️
client/daemon/peer/peertask_base.go 32.21% <0.00%> (-0.72%) ⬇️

@jim3ma jim3ma merged commit 6386cae into main Jul 13, 2021
@jim3ma jim3ma deleted the feature/default-scheduler-cluster branch July 13, 2021 02:48
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match schedulers according to client information
4 participants