Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: manager server new params #464

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • refactor manager server new params.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Jul 16, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner July 16, 2021 05:45
@gaius-qi gaius-qi self-assigned this Jul 16, 2021
@gaius-qi gaius-qi changed the title refactor: manager server new instance refactor: manager server new params Jul 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #464 (9e93556) into main (7659def) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   36.54%   36.54%           
=======================================
  Files          89       89           
  Lines        6959     6959           
=======================================
  Hits         2543     2543           
  Misses       4048     4048           
  Partials      368      368           
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 36.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gaius-qi gaius-qi merged commit a5e9510 into main Jul 19, 2021
@gaius-qi gaius-qi deleted the feature/manager-server branch July 19, 2021 07:29
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants