Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: register service to manager #475

Merged
merged 2 commits into from
Jul 20, 2021
Merged

feat: register service to manager #475

merged 2 commits into from
Jul 20, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jul 19, 2021

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Register service to manager

Related Issue

Fixes #469

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Jul 19, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner July 19, 2021 07:12
@gaius-qi gaius-qi self-assigned this Jul 19, 2021
Signed-off-by: Gaius <gaius.qi@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #475 (55ef562) into main (7659def) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
- Coverage   36.54%   36.51%   -0.03%     
==========================================
  Files          89       89              
  Lines        6959     6959              
==========================================
- Hits         2543     2541       -2     
- Misses       4048     4050       +2     
  Partials      368      368              
Flag Coverage Δ
e2etests ?
unittests 36.51% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 54.77% <0.00%> (-2.21%) ⬇️
client/daemon/peer/peertask_base.go 33.89% <0.00%> (+0.95%) ⬆️

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero yxxhero self-requested a review July 19, 2021 11:00
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit cffe414 into main Jul 20, 2021
@gaius-qi gaius-qi deleted the feature/manager-register branch July 20, 2021 02:14
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: register service to manager

Signed-off-by: Gaius <gaius.qi@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor manager interface module registration
4 participants