Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix scheduler pick candidate and associate child encounter dead lock #500

Merged
merged 2 commits into from
Jul 27, 2021

Conversation

244372610
Copy link
Contributor

@244372610 244372610 commented Jul 27, 2021

Description

Fix scheduler pick candidate and associate child encounter dead lock

Related Issue

fix #500

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
@244372610 244372610 requested a review from a team as a code owner July 27, 2021 07:19
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #500 (2679235) into main (733962f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   39.55%   39.54%   -0.01%     
==========================================
  Files          81       81              
  Lines        6285     6284       -1     
==========================================
- Hits         2486     2485       -1     
+ Misses       3441     3440       -1     
- Partials      358      359       +1     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.54% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/config/config.go 0.00% <0.00%> (ø)
client/daemon/peer/peertask_base.go 32.39% <0.00%> (-0.71%) ⬇️
client/daemon/peer/peertask_stream.go 56.98% <0.00%> (+0.73%) ⬆️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit fbbfcd3 into main Jul 27, 2021
@gaius-qi gaius-qi deleted the feature/optimizeSchedulerEntityLock branch July 27, 2021 07:36
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
…#500)

* fix dead lock

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants