Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix proxy for stress testing tool #507

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Fix proxy for stress testing tool #507

merged 2 commits into from
Jul 30, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Jul 28, 2021

Signed-off-by: Jim Ma majinjing3@gmail.com

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner July 28, 2021 06:11
gaius-qi
gaius-qi previously approved these changes Jul 28, 2021
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021

Codecov Report

Merging #507 (8ebca3f) into main (e655635) will decrease coverage by 0.09%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   39.59%   39.49%   -0.10%     
==========================================
  Files          81       81              
  Lines        6284     6289       +5     
==========================================
- Hits         2488     2484       -4     
- Misses       3437     3444       +7     
- Partials      359      361       +2     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.49% <36.36%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clientutil/keepalive.go 0.00% <ø> (ø)
client/daemon/peer/peertask_manager.go 19.25% <0.00%> (-0.15%) ⬇️
client/daemon/peer/peertask_reuse.go 0.00% <0.00%> (ø)
client/daemon/transport/transport.go 75.53% <ø> (ø)
client/daemon/upload/upload_manager.go 57.14% <25.00%> (ø)
client/daemon/storage/local_storage.go 31.45% <40.00%> (ø)
client/daemon/peer/peertask_stream.go 57.29% <100.00%> (+0.31%) ⬆️
client/daemon/peer/piece_manager.go 65.44% <0.00%> (-1.63%) ⬇️
client/daemon/service/manager.go 31.68% <0.00%> (-1.33%) ⬇️
client/daemon/peer/peertask_base.go 32.39% <0.00%> (-0.71%) ⬇️
... and 2 more

244372610
244372610 previously approved these changes Jul 28, 2021
Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma dismissed stale reviews from 244372610 and gaius-qi via 8ebca3f July 29, 2021 12:06
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit f98401d into main Jul 30, 2021
@gaius-qi gaius-qi deleted the feature/stress-testing branch July 30, 2021 02:56
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* chore: fix proxy for stress testing tool

Signed-off-by: Jim Ma <majinjing3@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants