Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/concurrent dead lock #509

Merged
merged 7 commits into from
Jul 29, 2021
Merged

Feature/concurrent dead lock #509

merged 7 commits into from
Jul 29, 2021

Conversation

244372610
Copy link
Contributor

@244372610 244372610 commented Jul 29, 2021

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
@244372610 244372610 requested a review from a team as a code owner July 29, 2021 06:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021

Codecov Report

Merging #509 (959674d) into main (e655635) will decrease coverage by 0.14%.
The diff coverage is 24.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   39.59%   39.44%   -0.15%     
==========================================
  Files          81       81              
  Lines        6284     6295      +11     
==========================================
- Hits         2488     2483       -5     
- Misses       3437     3450      +13     
- Partials      359      362       +3     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.44% <24.13%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdnsystem/server/service/cdn_seed_server.go 0.00% <ø> (ø)
client/daemon/daemon.go 0.00% <0.00%> (ø)
client/daemon/peer/peertask_base.go 32.94% <0.00%> (-0.16%) ⬇️
client/daemon/service/manager.go 31.68% <0.00%> (-1.33%) ⬇️
pkg/structure/sortedlist/sorted_list.go 56.31% <0.00%> (-2.28%) ⬇️
scheduler/config/config.go 0.00% <0.00%> (ø)
client/daemon/peer/peertask_file_callback.go 62.96% <25.00%> (ø)
client/daemon/peer/peertask_stream_callback.go 64.55% <25.00%> (ø)
client/daemon/peer/peertask_file.go 53.81% <50.00%> (+0.15%) ⬆️
client/daemon/peer/peertask_stream.go 55.10% <100.00%> (-1.88%) ⬇️
... and 5 more

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
gaius-qi
gaius-qi previously approved these changes Jul 29, 2021
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit a5e4b0e into main Jul 29, 2021
@gaius-qi gaius-qi deleted the feature/concurrentDeadLock branch July 29, 2021 12:09
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* fix scheduler concurrent dead lock

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants