Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature: support mysql 5.6 #520

Merged
merged 24 commits into from
Aug 5, 2021
Merged

Feature: support mysql 5.6 #520

merged 24 commits into from
Aug 5, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Aug 5, 2021

Description

  • Support mysql version < 5.7

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

gaius-qi added 22 commits July 29, 2021 16:19
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Aug 5, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner August 5, 2021 06:05
@gaius-qi gaius-qi self-assigned this Aug 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021

Codecov Report

Merging #520 (5c046fd) into main (83cd262) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   39.34%   39.15%   -0.19%     
==========================================
  Files          85       85              
  Lines        6438     6443       +5     
==========================================
- Hits         2533     2523      -10     
- Misses       3539     3555      +16     
+ Partials      366      365       -1     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.15% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager/config/config.go 0.00% <0.00%> (ø)
manager/permission/rbac/rbac.go 39.62% <0.00%> (ø)
client/daemon/peer/peertask_stream.go 55.07% <0.00%> (-2.54%) ⬇️
client/daemon/peer/peertask_base.go 32.24% <0.00%> (-0.71%) ⬇️

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi changed the title Feature/support mysql 5.6 Feature: support mysql 5.6 Aug 5, 2021
jim3ma
jim3ma previously approved these changes Aug 5, 2021
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi merged commit c0bc4a9 into main Aug 5, 2021
@gaius-qi gaius-qi deleted the feature/support-mysql-5.6 branch August 5, 2021 06:59
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: support mysql 5.6

Signed-off-by: Gaius <gaius.qi@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Bumps [rustls](https://github.com/rustls/rustls) from 0.22.2 to 0.22.4.
- [Release notes](https://github.com/rustls/rustls/releases)
- [Changelog](https://github.com/rustls/rustls/blob/main/CHANGELOG.md)
- [Commits](rustls/rustls@v/0.22.2...v/0.22.4)

---
updated-dependencies:
- dependency-name: rustls
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants