Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Method update to unanimous #535

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Method update to unanimous #535

merged 1 commit into from
Aug 12, 2021

Conversation

lengrongfu
Copy link
Contributor

Description

Related Issue

Issue: #532

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lengrongfu lengrongfu requested a review from a team as a code owner August 12, 2021 02:43
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #535 (481de25) into main (c1c3d65) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
- Coverage   39.47%   39.31%   -0.16%     
==========================================
  Files          86       86              
  Lines        6529     6529              
==========================================
- Hits         2577     2567      -10     
- Misses       3581     3592      +11     
+ Partials      371      370       -1     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.31% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdnsystem/storedriver/driver.go 16.66% <0.00%> (ø)
cdnsystem/storedriver/local/local_driver.go 51.89% <ø> (ø)
cdnsystem/storedriver/mock_driver.go 0.00% <0.00%> (ø)
client/daemon/peer/peertask_stream.go 55.05% <0.00%> (-2.44%) ⬇️
client/daemon/peer/peertask_base.go 34.33% <0.00%> (-0.65%) ⬇️

244372610
244372610 previously approved these changes Aug 12, 2021
Signed-off-by: lengrongfu <lenronfu@gmail.com>
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@244372610 244372610 merged commit 71ec3a1 into dragonflyoss:main Aug 12, 2021
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Signed-off-by: lengrongfu <lenronfu@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants