Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add distribute Schedule Tracer & Refactor scheduler #537

Merged
merged 18 commits into from
Aug 12, 2021
Merged

Conversation

244372610
Copy link
Contributor

@244372610 244372610 commented Aug 12, 2021

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
@244372610 244372610 requested a review from a team as a code owner August 12, 2021 08:44
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #537 (07a75fd) into main (25d58d4) will decrease coverage by 0.02%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   39.41%   39.39%   -0.03%     
==========================================
  Files          86       86              
  Lines        6536     6542       +6     
==========================================
+ Hits         2576     2577       +1     
- Misses       3590     3594       +4     
- Partials      370      371       +1     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.39% <23.07%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/daemon.go 0.00% <0.00%> (ø)
pkg/structure/sortedlist/sorted_list.go 56.31% <ø> (ø)
scheduler/config/config.go 4.49% <0.00%> (-0.16%) ⬇️
client/daemon/peer/peertask_file.go 54.05% <66.66%> (ø)
client/daemon/peer/peertask_stream.go 57.49% <100.00%> (+2.43%) ⬆️
client/daemon/peer/peertask_base.go 34.33% <0.00%> (-1.29%) ⬇️

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 0cc52f5 into main Aug 12, 2021
@gaius-qi gaius-qi deleted the feature/tracer branch August 12, 2021 10:10
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* check same cdn list avoid updating client too frequent

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants