Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Optimize peer task report function #543

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Optimize peer task report function #543

merged 1 commit into from
Aug 12, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Aug 12, 2021

Signed-off-by: Jim Ma majinjing3@gmail.com

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner August 12, 2021 13:51
gaius-qi
gaius-qi previously approved these changes Aug 12, 2021
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #543 (bf52584) into main (b36bd74) will increase coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   39.33%   39.39%   +0.06%     
==========================================
  Files          86       86              
  Lines        6542     6559      +17     
==========================================
+ Hits         2573     2584      +11     
- Misses       3599     3605       +6     
  Partials      370      370              
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.39% <50.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_dummy.go 0.00% <ø> (ø)
client/daemon/peer/peertask_manager.go 19.85% <ø> (ø)
client/daemon/peer/peertask_base.go 34.75% <12.50%> (-0.23%) ⬇️
client/daemon/peer/peertask_file.go 54.05% <50.00%> (ø)
client/daemon/peer/peertask_stream.go 55.05% <53.84%> (ø)
client/daemon/peer/piece_manager.go 67.19% <55.55%> (+0.66%) ⬆️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 2dd969c into main Aug 12, 2021
@gaius-qi gaius-qi deleted the feature/stability branch August 12, 2021 14:07
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Jim Ma <majinjing3@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Bumps [http-body-util](https://github.com/hyperium/http-body) from 0.1.0 to 0.1.2.
- [Commits](hyperium/http-body@http-body-util-v0.1.0...http-body-util-v0.1.2)

---
updated-dependencies:
- dependency-name: http-body-util
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants