Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: rename task to job #544

Merged
merged 2 commits into from
Aug 12, 2021
Merged

feat: rename task to job #544

merged 2 commits into from
Aug 12, 2021

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Rename task to job.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Aug 12, 2021
@gaius-qi gaius-qi self-assigned this Aug 12, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner August 12, 2021 14:05
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #544 (964a5de) into main (b36bd74) will increase coverage by 0.06%.
The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
+ Coverage   39.33%   39.39%   +0.06%     
==========================================
  Files          86       86              
  Lines        6542     6559      +17     
==========================================
+ Hits         2573     2584      +11     
- Misses       3599     3605       +6     
  Partials      370      370              
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.39% <11.76%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/job/job.go 21.15% <0.00%> (ø)
internal/job/queue.go 85.71% <ø> (ø)
scheduler/config/config.go 4.49% <50.00%> (ø)
client/daemon/peer/peertask_base.go 34.75% <0.00%> (-0.23%) ⬇️
client/daemon/peer/peertask_dummy.go 0.00% <0.00%> (ø)
client/daemon/peer/piece_manager.go 67.19% <0.00%> (+0.66%) ⬆️

Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 5286be0 into main Aug 12, 2021
@gaius-qi gaius-qi deleted the feature/rename-asynctask-to-job branch August 12, 2021 14:36
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: rename task to job

Signed-off-by: Gaius <gaius.qi@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Bumps termion from 4.0.0 to 4.0.2.

---
updated-dependencies:
- dependency-name: termion
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants