Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: optimize get permission name #548

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Optimize get permission name.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Aug 13, 2021
@gaius-qi gaius-qi self-assigned this Aug 13, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner August 13, 2021 10:36
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #548 (8da4506) into main (5286be0) will decrease coverage by 0.19%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   39.47%   39.27%   -0.20%     
==========================================
  Files          86       86              
  Lines        6559     6553       -6     
==========================================
- Hits         2589     2574      -15     
- Misses       3599     3607       +8     
- Partials      371      372       +1     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.27% <75.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager/permission/rbac/rbac.go 34.04% <75.00%> (-5.59%) ⬇️
client/daemon/peer/peertask_stream.go 54.00% <0.00%> (-3.49%) ⬇️
client/daemon/peer/peertask_stream_callback.go 62.02% <0.00%> (-2.54%) ⬇️
client/daemon/peer/peertask_file.go 54.05% <0.00%> (-0.39%) ⬇️
client/daemon/peer/peertask_base.go 34.75% <0.00%> (+0.63%) ⬆️

@gaius-qi gaius-qi merged commit b1d88d6 into main Aug 17, 2021
@gaius-qi gaius-qi deleted the feature/get-permission-name branch August 17, 2021 02:56
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants