Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix cdn back source range size overflow #550

Merged
merged 1 commit into from
Aug 15, 2021
Merged

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Aug 13, 2021

Signed-off-by: Jim Ma majinjing3@gmail.com

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner August 13, 2021 12:01
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #550 (00c5c5f) into main (5286be0) will increase coverage by 0.05%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   39.47%   39.53%   +0.05%     
==========================================
  Files          86       86              
  Lines        6559     6562       +3     
==========================================
+ Hits         2589     2594       +5     
+ Misses       3599     3597       -2     
  Partials      371      371              
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.53% <69.23%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdnsystem/daemon/cdn/cache_writer.go 79.20% <69.23%> (+0.63%) ⬆️
client/daemon/peer/peertask_file.go 54.05% <0.00%> (-0.39%) ⬇️
client/daemon/peer/peertask_base.go 34.75% <0.00%> (+0.63%) ⬆️

@jim3ma jim3ma merged commit 55e8245 into main Aug 15, 2021
@jim3ma jim3ma deleted the fix/cdn-back-source-overflow branch August 15, 2021 06:05
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Jim Ma <majinjing3@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants