Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

change rabc code struct #552

Merged
merged 10 commits into from
Aug 24, 2021
Merged

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Aug 15, 2021

Signed-off-by: yxxhero aiopsclub@163.com

Description

Related Issue

#546

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yxxhero yxxhero requested a review from a team as a code owner August 15, 2021 09:44
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2021

Codecov Report

Merging #552 (730df5d) into main (fb54969) will not change coverage.
The diff coverage is 12.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files          86       86           
  Lines        6641     6641           
=======================================
  Hits         2607     2607           
+ Misses       3665     3664    -1     
- Partials      369      370    +1     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.25% <12.50%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager/permission/rbac/rbac.go 21.27% <12.50%> (-12.77%) ⬇️
client/daemon/peer/piece_manager.go 67.19% <0.00%> (-0.80%) ⬇️
client/daemon/peer/peertask_stream.go 56.79% <0.00%> (+0.69%) ⬆️
client/daemon/peer/peertask_base.go 35.31% <0.00%> (+1.27%) ⬆️

@yxxhero yxxhero self-assigned this Aug 15, 2021
@yxxhero yxxhero linked an issue Aug 15, 2021 that may be closed by this pull request
Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 2621b5e into dragonflyoss:main Aug 24, 2021
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* feat: change rabc code struct

Signed-off-by: yxxhero <aiopsclub@163.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
…to usize::MAX (dragonflyoss#552)

Signed-off-by: Gaius <gaius.qi@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manager RBAC
4 participants