Add a function to check task existence in cdn #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #570 +/- ##
==========================================
- Coverage 39.28% 39.13% -0.16%
==========================================
Files 86 86
Lines 6641 6644 +3
==========================================
- Hits 2609 2600 -9
- Misses 3661 3675 +14
+ Partials 371 369 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
244372610
previously approved these changes
Aug 23, 2021
Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
244372610
approved these changes
Aug 24, 2021
gaius-qi
pushed a commit
that referenced
this pull request
Jun 28, 2023
* fix: replace get with exist in gc Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com> * fix: no error in the if branch Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com> * fix: move accessTimeMap.Add from getTask into Get Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com> * fix: change return value Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com> * fix: remove log error for Exist don't return error Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com> * chore: use mockgen Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com> * chore: merge submodule Signed-off-by: zzy987 <67889264+zzy987@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cdn check task existence in gc, it will call taskMgr.Get which will update the accessTimeMap in manager. I add a Exist method to replace the Get in gc.